Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed 4405: update openAPI docs for list findings #974

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

brandonshearin
Copy link
Contributor

@brandonshearin brandonshearin commented Nov 22, 2024

Description

  • remove exposureCount/Percentage from list findings in the v2/attack-paths/domain/details endpoint

Motivation and Context

This PR addresses: BED-4405

How Has This Been Tested?

  • ran just gen-spec locally and verified that the changes were reflected in the API explorer

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Database Migrations

Checklist:

@brandonshearin brandonshearin self-assigned this Nov 22, 2024
@brandonshearin brandonshearin added documentation Improvements or additions to documentation api A pull request containing changes affecting the API code. labels Nov 22, 2024
Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here, and this is standalone. Feel free to pull to main now rather than wait for your open MR to be ready.

@brandonshearin brandonshearin merged commit 48f6949 into main Nov 25, 2024
4 checks passed
@brandonshearin brandonshearin deleted the BED-4405 branch November 25, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants