Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4291 refactor: cleanup orphaned SAML logic and persist root uri versions to db #964

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Nov 16, 2024

Description

  • Cleaned up the old orphaned SAML logic
  • Cleaned up saml_provider_id from users and reliance on it in business logic
  • Cleaned up multi-instantiation of resources during routing bootstrapping
  • Introduce root_uri_version to saml_providers in DB as a solution for maintaining backwards compatibility with existing SAML providers
  • Add /metadata endpoint to new SSO structure

Motivation and Context

This PR addresses: BED-4291

Why is this change required? What problem does it solve?

A lot of the old SAML logic needed to be cleaned up once generalized SSO support was added. Additionally, this enables a way for existing SAML providers to exist while new SAML providers can rely on the new SSO auth flow

How Has This Been Tested?

Unit tests + locally

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database Migrations

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Nov 16, 2024
@mistahj67 mistahj67 self-assigned this Nov 16, 2024
@mistahj67 mistahj67 force-pushed the BED-4291 branch 5 times, most recently from 41e0f51 to 6d02711 Compare November 20, 2024 20:13
@mistahj67 mistahj67 merged commit 00365c3 into main Nov 22, 2024
4 checks passed
@mistahj67 mistahj67 deleted the BED-4291 branch November 22, 2024 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants