-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESC 6B Edge Composition #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urangel
reviewed
Feb 1, 2024
urangel
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you please update the 6b integration test to test for the edge composition in one of the harnesses?
urangel
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset adds the edge composition handler for the ESC 6B edge.
GetADCSESC6bEdgeComposition
function inesc6.go
, follows the same approach as the handler for ESC 6Aesc6.go
that each handle a different part of the traversal needed for compositionMotivation and Context
when a graph is rendered on the explore page that contains an esc 6b edge, the user should be able to click on the edge, and then click on the "composition" panel of the entity info content panel, and a new graph should render of all the implicit paths that a 6B edge needs.
How Has This Been Tested?
Screenshots (if appropriate):
after expanding a 6B edge:
Types of changes
Checklist: