Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC 6B Edge Composition #379

Merged
merged 14 commits into from
Feb 2, 2024
Merged

ESC 6B Edge Composition #379

merged 14 commits into from
Feb 2, 2024

Conversation

brandonshearin
Copy link
Contributor

@brandonshearin brandonshearin commented Feb 1, 2024

Description

This changeset adds the edge composition handler for the ESC 6B edge.

  • new GetADCSESC6bEdgeComposition function in esc6.go, follows the same approach as the handler for ESC 6A
  • four helper functions in esc6.go that each handle a different part of the traversal needed for composition
  • the repeated boilerplate composition component was added to the shared ui

Motivation and Context

when a graph is rendered on the explore page that contains an esc 6b edge, the user should be able to click on the edge, and then click on the "composition" panel of the entity info content panel, and a new graph should render of all the implicit paths that a 6B edge needs.

How Has This Been Tested?

Screenshots (if appropriate):

after expanding a 6B edge:
Screenshot 2024-02-01 at 11 26 31 AM

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@brandonshearin brandonshearin changed the title draft: ESC 6B Edge Composition ESC 6B Edge Composition Feb 1, 2024
Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you please update the 6b integration test to test for the edge composition in one of the harnesses?

@brandonshearin brandonshearin merged commit 6f1afda into main Feb 2, 2024
3 checks passed
@brandonshearin brandonshearin deleted the BED-4015 branch February 2, 2024 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants