Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more auth handlers for audit log #373

Merged
merged 2 commits into from
Jan 31, 2024
Merged

more auth handlers for audit log #373

merged 2 commits into from
Jan 31, 2024

Conversation

irshadaj
Copy link
Contributor

Audit logging for database methods:

  • CreateUser
  • DeleteUser
  • DeleteAuthSecret

Also added unit tests for the uncovered endpoint to delete users.

@irshadaj irshadaj self-assigned this Jan 31, 2024
superlinkx
superlinkx reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to fix a previously broken window. Doesn't block my approval though, merge when ready

cmd/api/src/api/v2/auth/auth.go Outdated Show resolved Hide resolved
@irshadaj irshadaj merged commit d744c31 into populate-audit-log-fields Jan 31, 2024
3 checks passed
@irshadaj irshadaj deleted the 81012 branch January 31, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@superlinkx superlinkx superlinkx approved these changes

Assignees

@irshadaj irshadaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irshadaj @superlinkx