audit logs for auth tokens and secrets #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is any of this audit logging under test right now? |
We have an integration test that exercises the audit log and ensures data is being written and read properly. There haven't been many other e2e tests that end up exercising the audit log that we've found so far, and that's a gap we want to close, but for now that's going to be out of scope given our sensitive timeline. Additional testing is planned before the final merge of our feature branch, but we've gotta get code complete first and see how much time we have to add tests |
superlinkx
reviewed
Jan 31, 2024
superlinkx
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added audit logging for database handlers: