-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: audit log steel thread #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `AuditableContext` method to the Database, which wraps the Gorm Transaction method with some auditing context and ensures the two phase commit of the audit log is run
fix: use actual AuditData instead of the direct model
…audit-log-steel-thread
fix: broken tests
fix: incorrect formatting of audit log action names fix: additional test fixes
juggernot325
approved these changes
Jan 30, 2024
irshadaj
reviewed
Jan 30, 2024
irshadaj
reviewed
Jan 30, 2024
irshadaj
reviewed
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steel Thread for Audit Logging
Motivation and Context
We needed to change our approach to audit logging. This contains the first 4 DB methods to get audit logging to use as reference for our other priority 1 audit enabled methods.
How Has This Been Tested?
Existing tests were modified as necessary, but generally kept as close to the originals as possible. Passing tests means there's good confidence that these changes are correct, but additional testing should be completed before the main
populate-audit-log-fields
gets merged.Types of changes
Checklist: