-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: slices cleanup #361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we move to 1.22+ in the future) chore: update a couple of examples where Concat simplifies our code significantly
zinic
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments. Merge when passing.
sircodemane
reviewed
Jan 31, 2024
sircodemane
reviewed
Jan 31, 2024
sircodemane
reviewed
Jan 31, 2024
sircodemane
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refocuses our internal
slices
module as an extension of the newly available Go 1.21+ stdlibslices
package. This involved renaming our slices module toslicesext
and removing functions that stdlib now provides. All features that ourslicesext
module provide that the stdlib doesn't were kept as is.This also backports an upcoming stdlib
slices
function into our extension module: Append!Motivation and Context
slices
module became a bit unwieldy after the upgrade to Go 1.21, since it directly collides with the name of the stdlib package with a different set of features, but some overlapslicesext
uses the current version of this function since it's a fairly stable piece of code and isn't expected to have any API changes between now and Go 1.22 full release. When we eventually upgrade to Go 1.22, we can delete our copy as well as the copied test from our extension, but for now it lets us start using Append with a clean refactor path.How Has This Been Tested?
All tests continue to pass. New tests added for new function (stolen and slightly tweaked from Go source).
Types of changes
Checklist: