Fix building with node 10.0.0 #71
Conversation
|
If i have more free time, i will fix backward incompatibilities with older nodejs versions. The problem is with OpenSSL version that is changed from 1.0.x to 1.1.x in nodeJS v10.x |
|
OK, finally it work on every nodejs version. |
|
Bravo! |
|
@Southern bump plz (needed for node-solid) |
|
plz merge it |
|
ASAP |
|
build already green |
|
I am also waiting for this merge. Till then, i am using my own fork in my projects |
|
Bump
…On Thu, Jul 19, 2018, 3:16 PM Vlado Velichkovski ***@***.***> wrote:
I am also waiting for this merge. Till then, i am using my own fork in my
projects
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKBbE7w5wNheCYxJcbCNeN-Z_60dYH2ks5uINr0gaJpZM4VGc1->
.
|
|
Guys, you can just use it from github: |
|
@Paxa Thanks for this patch very much, may I ask you not to change the coding style, such that we could merge them only with building patch :) |
|
Did the project die? |
|
Bump |
|
Can this be merged please? |
| Local<Value> try_parse(const std::string& dataString); | ||
| Local<Value> verify(const std::string& dataString); | ||
| Local<Value> try_parse(const std::string &dataString); | ||
| Local<Value> verify(const std::string &dataString); |
There was a problem hiding this comment.
Could you please revert these style changes?
There was a problem hiding this comment.
i wish someone just edited these files using github inline edit :)
| char* real_name(char *data); | ||
| char* trim(char *data, int len); | ||
| char *real_name(char *data); | ||
| char *trim(char *data, int len); |
| Nan::Set(exports, Nan::New<String>("getIssuer").ToLocalChecked(), | ||
| Nan::New<FunctionTemplate>(get_issuer)->GetFunction()); | ||
| Nan::Set(exports, Nan::New<String>("parseCert").ToLocalChecked(), | ||
| Nan::New<FunctionTemplate>(parse_cert)->GetFunction()); | ||
| } |
There was a problem hiding this comment.
Please use the 2 spaces as indents.
@mbwhite Sorry for the late, already leave comments here though the CI is pass :) |
|
OK, i will try to fix this styling stuffs and also will try to fix some warnings for node v11. Will do a new commits today or tomorrow |
|
@stormwin you awesome! |
|
Bump. @stormwin any chance that you fixed that styling ? |
This is the #71 but with corrected formatting as per the discussion in #71 Thank you to those who worked on fix; aim here is to get the fix merged as it is needed by many projects Signed-off-by: Matthew B. White <[email protected]>
|
Anyone can resolve the conflicts? |
|
there any follow up? |
We would have preferred to use this repo - but due to schedules we had to fork and republished to npm. |
I found this useful patch in #68 (i'm not an author of this changes)
Thank you @stormwin