Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings in node 8 #54

Closed
wants to merge 1 commit into from

Conversation

deepakrkris
Copy link

@deepakrkris deepakrkris commented Jul 28, 2017

  • Update Nan version in package.json to 2.6.2

  • Use Nan::CallAsConstructor instead of v8::Object::CallAsConstructor

#53

* Update Nan version in package.json to 2.6.2

* Use Nan::CallAsConstructor instead of v8::Object::CallAsConstructor
@deepakrkris
Copy link
Author

deepakrkris commented Jul 31, 2017

@Southern please review

@tanuck
Copy link
Contributor

tanuck commented Aug 1, 2017

I think the versions list for travis should be updated before merging this, just to be sure of backwards compatibility.

@deepakrkris
Copy link
Author

@tanuck thank you for your observation , do you want to update the semver to 0.3.3 before merging this change ?

@deepakrkris
Copy link
Author

@Southern @tanuck please review and comment

@tanuck
Copy link
Contributor

tanuck commented Aug 25, 2017

@deepakrkris sorry but I don't have the ability to merge. So you'll have to wait on @Southern

@deepakrkris
Copy link
Author

@Southern is this PR good to merge ? or do you want to close this , since it has been more than 8 months

@gzurbach
Copy link

Would like to see this merged as well.

@mbwhite
Copy link
Contributor

mbwhite commented Nov 20, 2018

Ditto the merge of this one; we've found it raises lots of questions with end users to see the warnings go past.

@deepakrkris
Copy link
Author

closing as this was fixed in #74

@deepakrkris deepakrkris closed this Jan 9, 2019
@deepakrkris deepakrkris deleted the fix-node8-warnings branch January 9, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants