-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for parsing a certificate with an extension attribute with a NULL-value #39
Open
mwpnl
wants to merge
2
commits into
Southern:master
Choose a base branch
from
mwpnl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
added fix for when an cert-extension attribute had a value of NULL th…
…at would break processing the rest of the certificate.
- Loading branch information
commit eb0249519825bbaa668a344b79f8c4ec305f710b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -277,12 +277,16 @@ Local<Value> try_parse(const std::string& dataString) { | |
BUF_MEM *bptr; | ||
BIO_get_mem_ptr(ext_bio, &bptr); | ||
BIO_set_close(ext_bio, BIO_CLOSE); | ||
|
||
char *data = (char*) malloc(bptr->length + 1); | ||
BUF_strlcpy(data, bptr->data, bptr->length + 1); | ||
data = trim(data, bptr->length); | ||
|
||
BIO_free(ext_bio); | ||
if (bptr->data == NULL){ | ||
BIO_free(ext_bio); | ||
data=""; | ||
} else { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove |
||
BUF_strlcpy(data, bptr->data, bptr->length ); | ||
data = trim(data, bptr->length); | ||
BIO_free(ext_bio); | ||
} | ||
|
||
unsigned nid = OBJ_obj2nid(obj); | ||
if (nid == NID_undef) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the better option would be to not run the allocation or anything that deals with data unless
bptr->data != NULL
.