Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue building with node 10.0.0? #68

Open
Ubunfu opened this issue May 8, 2018 · 2 comments
Open

Issue building with node 10.0.0? #68

Ubunfu opened this issue May 8, 2018 · 2 comments

Comments

@Ubunfu
Copy link

Ubunfu commented May 8, 2018

After upgrading to node 10.0.0, I had some issues installing x509. node-gyp 'make' was failing with some errors that seemed indicative of some kind of breaking interface change. However this is not the analysis of an expert in such things :) Downgrading node to 9.5.0 (or 9.11.1) fixes the issue without any further action needed. If this is actually an issue with node, or node-gyp, or my own environment, please accept my apologies and close this issue!
10.0.0_build.log

@neilstuartcraig
Copy link

neilstuartcraig commented May 16, 2018

I have the exact same issue (node 10 via nvm). From a cursory scan over the output, it looks like something in x509 is using features which were deprecated in node 9 and removed in node 10:

../../nan/nan_maybe_43_inl.h:112:15: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
              ^
/Users/craign04/.node-gyp/9.9.0/include/node/v8.h:3164:3: note: 'ForceSet' has been explicitly marked deprecated here
  V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty",
  ^
/Users/craign04/.node-gyp/9.9.0/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))

Looks like it might be the version of nan perhaps? (i'm not very familiar with nan in any detail).

Downgrading to node 9 works but there are warnings WRT deprecations.

Happy to take a look it that's helpful.

Update:
It's not nan (although the version of nan in this package is older than current). It's some issues in the C code, similar to this https://stackoverflow.com/questions/45639996/c-error-member-access-into-incomplete-type-in-base-class-virtual-function

@stormwin
Copy link

stormwin commented Jun 17, 2018

For Nodejs v10+, you can use my fork: https://github.com/stormwin/node-x509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants