Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstdlib] optimize CCvar::FindCommandBase #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RaphaelIT7
Copy link
Contributor

optimized CCvar::FindCommandBase
I made this optimization today and didn't find any issues, so it should work fine.
It's quiet a significant improvement but I don't got exact numbers, but from what I experienced it should be like 10x?
The improvement should become bigger with each new command/convar being added.

@dimhotepus dimhotepus force-pushed the master branch 5 times, most recently from b388518 to 76fe8e0 Compare December 7, 2024 12:46
Origin: 40d80d0

Just made this optimization, but since I found no issues with it, it should work fine
@RaphaelIT7
Copy link
Contributor Author

Just found a bug when testing it again, the source engine uses V_stricmp when comparing making FindCommandBase case-insensitive, and I failed to account for it making it currently case-sensitive.
I'll push a fix a bit later for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant