Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button7 Implement #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

button7 Implement #3

wants to merge 3 commits into from

Conversation

0gonge
Copy link
Contributor

@0gonge 0gonge commented May 31, 2024

Summary⭕️

Implement CalculatorUI with button 7.
When I press the number 7, 7 is pressed.

Describe Changes🔴

The boss JiSeok told me to refactor, but I plan to try pressing buttons first and reduce the code.
Still Refectoring.

I had to revert it in the middle because git was messed up : ( , but I plan to fix the .DS_Store-related conflict that occurred and merge it.
I will modify it later. : )
Thankyou
#2 UI

@0gonge 0gonge requested a review from sozohoy May 31, 2024 18:53
@0gonge 0gonge self-assigned this May 31, 2024
Copy link
Member

@sozohoy sozohoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 지금은 ButtonNumber라는 배열을 선언해서 UI를 구현해주었지만, 얘네를 따로 Enum으로 묶어 활용하는 방법 혹은 구조체로 모델을 선언하는 방법등의 좋은 방법들이 더 있을 수 있을 것 같아!!
  • 아무튼 늦었지만 제출해줘서 고맙고, 리펙토링 하느라 수고 많았어!

.cornerRadius(40)
.foregroundColor(.white)
.font(.system(size: 33))
ForEach(buttonNumber, id:\.self) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 확실히 ForEach를 사용하니까 코드가 많이 줄었다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants