Fix empty impacts for hotspots

SonarSource · Nov 4, 2024 · fbe6a10 · fbe6a10
1 parent db7ae38
commit fbe6a10
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/main/java/org/sonarlint/intellij/finding/LiveFinding.java b/src/main/java/org/sonarlint/intellij/finding/LiveFinding.java
@@ -95,9 +95,15 @@ protected LiveFinding(Module module, RaisedFindingDto finding, VirtualFile virtu
       this.severity = null;
       this.cleanCodeAttribute = CleanCodeAttribute.fromDto(finding.getSeverityMode().getRight().getCleanCodeAttribute());
       this.impacts = finding.getSeverityMode().getRight().getImpacts();
-      var highestQualityImpact = Collections.max(impacts, Comparator.comparing(ImpactDto::getImpactSeverity));
-      this.highestQuality = SoftwareQuality.fromDto(highestQualityImpact.getSoftwareQuality());
-      this.highestImpact = ImpactSeverity.fromDto(highestQualityImpact.getImpactSeverity());
+      // Is empty for Security Hotspots
+      if (!impacts.isEmpty()) {
+        var highestQualityImpact = Collections.max(impacts, Comparator.comparing(ImpactDto::getImpactSeverity));
+        this.highestQuality = SoftwareQuality.fromDto(highestQualityImpact.getSoftwareQuality());
+        this.highestImpact = ImpactSeverity.fromDto(highestQualityImpact.getImpactSeverity());
+      } else {
+        this.highestQuality = null;
+        this.highestImpact = null;
+      }
     }
   }