Skip to content

Commit

Permalink
SLI-593 Remove the module level configurable UI (#1206)
Browse files Browse the repository at this point in the history
  • Loading branch information
nquinquenel authored Oct 17, 2024
1 parent 9a66d76 commit c69366a
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 284 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
import static org.sonarlint.intellij.common.util.SonarLintUtils.isBlank;

public final class SonarLintModuleSettings {
private String sqPathPrefix = "";
private String idePathPrefix = "";

private String projectKey = "";

public String getProjectKey() {
Expand All @@ -42,19 +41,4 @@ public void clearBindingOverride() {
this.projectKey = "";
}

public String getSqPathPrefix() {
return sqPathPrefix;
}

public void setSqPathPrefix(String sqPathPrefix) {
this.sqPathPrefix = sqPathPrefix;
}

public String getIdePathPrefix() {
return idePathPrefix;
}

public void setIdePathPrefix(String idePathPrefix) {
this.idePathPrefix = idePathPrefix;
}
}
1 change: 0 additions & 1 deletion src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@
<toolWindow id="SonarLint" anchor="bottom" icon="org.sonarlint.intellij.SonarLintIcons.SONARLINT_TOOLWINDOW_EMPTY" factoryClass="org.sonarlint.intellij.ui.SonarLintToolWindowFactory" canCloseContents="true"/>
<applicationConfigurable groupId="tools" id="sonarlint" displayName="SonarLint" instance="org.sonarlint.intellij.config.global.SonarLintGlobalConfigurable"/>
<projectConfigurable parentId="sonarlint" displayName="Project Settings" instance="org.sonarlint.intellij.config.project.SonarLintProjectConfigurable" nonDefaultProject="true"/>
<moduleConfigurable id="SonarLint" displayName="SonarLint" instance="org.sonarlint.intellij.config.module.SonarLintModuleConfigurable"/>
<colorSettingsPage implementation="org.sonarlint.intellij.config.SonarLintColorSettingsPage"/>
<checkinHandlerFactory implementation="org.sonarlint.intellij.trigger.SonarLintCheckinHandlerFactory"/>
<additionalTextAttributes scheme="Default" file="colorSchemes/SonarLintDefault.xml"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Duration;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
Expand All @@ -61,8 +60,6 @@
import org.sonarlint.intellij.ui.SonarLintConsoleTestImpl;

import static com.intellij.notification.NotificationsManager.getNotificationsManager;
import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.await;
import static org.sonarlint.intellij.common.util.SonarLintUtils.getService;
import static org.sonarlint.intellij.config.Settings.getSettingsFor;

Expand Down Expand Up @@ -99,8 +96,6 @@ final void beforeEachLightTest(TestInfo testInfo) throws Exception {
getProjectSettings().setBindingEnabled(false);
getProjectSettings().setBindingSuggestionsEnabled(true);
setProjectLevelExclusions(Collections.emptyList());
getModuleSettings().setIdePathPrefix("");
getModuleSettings().setSqPathPrefix("");
getModuleSettings().clearBindingOverride();
getService(BackendService.class).moduleUnbound(getModule());
getService(BackendService.class).projectUnbound(getProject());
Expand Down

0 comments on commit c69366a

Please sign in to comment.