-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT SQUASH] SCSCANGHA-25 Remove docker and SCSCANGHA-28 Rebranding #98
base: master
Are you sure you want to change the base?
[DO NOT SQUASH] SCSCANGHA-25 Remove docker and SCSCANGHA-28 Rebranding #98
Conversation
52f3442
to
2266b83
Compare
.github/workflows/qa.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this action is going to be deprecated, and all it does is to forward to sonarqube-scan-action
, I have only kept the tests about the input parameters of the action, which ensure that all the input parameters are forwarded to the sonarqube-scan-action
accordingly.
All the other tests are done in the sonarqube-scan-action
, including the one on SC Url env var.
![Logo](./images/SQ_Logo_Cloud_Dark_Backgrounds.png#gh-dark-mode-only) | ||
![Logo](./images/SQ_Logo_Cloud_Light_Backgrounds.png#gh-light-mode-only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having both dart and light logos with #gh-dark-mode-only
and #gh-light-mode-only
fragments make the logo responsive to the theme of the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these test files were used by QA workflow tests which now are only executed in the QA of sonarqube-scan-action
. So I have removed them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in line with the README of sonarqube-scan-action
, except that there are only references to SonarQube Cloud.
2266b83
to
7dd05b6
Compare
7dd05b6
to
1559164
Compare
Adding @agigleux to validate the warning message (check description in the PR). |
…ng to the SonarQube action
1559164
to
5976daa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR contains two tasks:
[email protected]
(fully-fixed version)We have also added a warning:
Successful test: https://github.com/antonioaversa/dart-tools-test2/actions/runs/12086908914/job/33707231926?pr=1