Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT SQUASH] SCSCANGHA-25 Remove docker and SCSCANGHA-28 Rebranding #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antonioaversa
Copy link

@antonioaversa antonioaversa commented Nov 29, 2024

This PR contains two tasks:

We have also added a warning:

  • in the README
  • in the logs
  • in the annotations

image
image
image

Successful test: https://github.com/antonioaversa/dart-tools-test2/actions/runs/12086908914/job/33707231926?pr=1

@antonioaversa antonioaversa force-pushed the antonio/SCSCANGHA-25-28-remove-docker-and-rebranding branch from 52f3442 to 2266b83 Compare November 29, 2024 14:25
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this action is going to be deprecated, and all it does is to forward to sonarqube-scan-action, I have only kept the tests about the input parameters of the action, which ensure that all the input parameters are forwarded to the sonarqube-scan-action accordingly.
All the other tests are done in the sonarqube-scan-action, including the one on SC Url env var.

Comment on lines +10 to +11
![Logo](./images/SQ_Logo_Cloud_Dark_Backgrounds.png#gh-dark-mode-only)
![Logo](./images/SQ_Logo_Cloud_Light_Backgrounds.png#gh-light-mode-only)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having both dart and light logos with #gh-dark-mode-only and #gh-light-mode-only fragments make the logo responsive to the theme of the user.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these test files were used by QA workflow tests which now are only executed in the QA of sonarqube-scan-action. So I have removed them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in line with the README of sonarqube-scan-action, except that there are only references to SonarQube Cloud.

@antonioaversa antonioaversa force-pushed the antonio/SCSCANGHA-25-28-remove-docker-and-rebranding branch from 2266b83 to 7dd05b6 Compare November 29, 2024 14:50
action.yml Outdated Show resolved Hide resolved
@antonioaversa antonioaversa force-pushed the antonio/SCSCANGHA-25-28-remove-docker-and-rebranding branch from 7dd05b6 to 1559164 Compare November 29, 2024 15:18
@antonioaversa antonioaversa requested review from a team and agigleux November 29, 2024 15:22
@antonioaversa
Copy link
Author

Adding @agigleux to validate the warning message (check description in the PR).

@antonioaversa antonioaversa force-pushed the antonio/SCSCANGHA-25-28-remove-docker-and-rebranding branch from 1559164 to 5976daa Compare December 2, 2024 15:53
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants