Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch argument escaping #1751

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Nov 7, 2023

Fixes #1706

Should be merged after #1752

Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@andrei-epure-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource what's the state of this?

@martin-strecker-sonarsource
Copy link
Contributor Author

Inconclusive. We have different behavior for different Java runtimes. The best solution is the current state. I wasn't able to get the PR green. It is either green locally or in CI because I have a different runtime than on CI.

@andrei-epure-sonarsource
Copy link
Contributor

Ok... could you give an update on the issue to share this state?
If the best solution is the current state, should we close the issue as won't fix?
Is there a way to detect this and fail, with a friendly error message?

@martin-strecker-sonarsource
Copy link
Contributor Author

Is there a way to detect this and fail with a friendly error message?

Unfortunatly no. The JDK used is detected by the scanner-cli.bat and is out of our control. The parameters are passed already, then.

If the best solution is the current state, should we close the issue as it won't be fixed?

Yes. I think so. The current solution is the most reliable one, and we still need to find out what exactly breaks it (we still do not have a full re-producer - just some assumptions/guesses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarScanner for .net doesn't sending result to server.
2 participants