SONARPY-2346 Remove usage of old ProjectLevelSymbolTable#from using V1 symbols #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghislainpiot
changed the title
Seppli11
requested changes
Dec 2, 2024
python-frontend/src/main/java/org/sonar/python/semantic/ProjectLevelSymbolTable.java
Outdated
Show resolved
Hide resolved
python-frontend/src/main/java/org/sonar/python/semantic/ProjectLevelSymbolTable.java
Show resolved
Hide resolved
python-frontend/src/test/java/org/sonar/python/semantic/ProjectLevelSymbolTableTest.java
Show resolved
Hide resolved
python-frontend/src/test/java/org/sonar/python/semantic/ProjectLevelSymbolTableTest.java
Outdated
Show resolved
Hide resolved
| classASymbol.addSuperClass(new SymbolImpl("BaseException", "BaseException")); | ||
| Map<String, Set<Descriptor>> globalDescriptors = Collections.singletonMap("mod1", | ||
| Collections.singleton( | ||
| new ClassDescriptor("A", "mod1.A", Collections.singleton("BaseException"), Set.of(), false, null, false, false, null, false))); | ||
| FileInput tree = parse( |
There was a problem hiding this comment.
nitpick: Could a ClassDescriptorBuilder be used?
python-frontend/src/test/java/org/sonar/python/semantic/ProjectLevelSymbolTableTest.java
Outdated
Show resolved
Hide resolved
ghislainpiot
force-pushed
the
SONARPY-2346
branch
from
ecff6b5 to
ad67906
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2394