Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC migration to Kotlin Analysis API #479

Draft
wants to merge 117 commits into
base: godin/kotlin-analysis-api
Choose a base branch
from
Draft

PoC migration to Kotlin Analysis API #479

wants to merge 117 commits into from

Conversation

leveretka
Copy link
Contributor

@leveretka leveretka commented Nov 19, 2024 •
edited by Godin
Loading

Done

git lg 2.21.0.5736..master -p | grep "\[email protected]" | wc -l
git lg 2.21.0.5736..master | grep Migrate | grep Check | grep -v CallAbstractCheck | grep -v AbstractRegexCheck
git diff 643b3f7d..master --stat -- "sonar-kotlin-checks/**/*Check.kt"

Remains

git diff master..HEAD --stat -- "sonar-kotlin-checks/**/*Check.kt"

git diff master..HEAD --name-only -G "diagnostics" -- "sonar-kotlin-checks/**/*Check.kt"

Godin and others added 30 commits October 9, 2024 12:30
@Godin
SONARKT-399 Fix shadowJar configuration
38c1024 
This was overlooked during replacement of
"kotlin-compiler-embeddable" by "kotlin-compiler"
in d7a5cfd.
@Godin
Remove obsolete code
d4fbea8 
This was overlooked in 7f85757.
@Godin
SONARKT-398 Upgrade Kotlin compiler to 2.0.21
1dfc63a
@Godin
Get rid of @OptIn(IDEAPluginsCompatibilityAPI::class)
6cf2db2
@Godin
Generate aggregate coverage report and import it into Sonar
c60ff8f
@Godin
Enable checksum verification of dependencies
a5daf15
@Godin
BUILD-6709 Change CODEOWNERS
b66d10a
@Godin
SONARKT-363 Fix ClassCastException in RedundantMethodsInDataClassesCheck
5770f81
@Godin
SONARKT-388 Fix IllegalArgumentException in CollectionShouldBeImmutab…
3efe09b 
…leCheck
@Godin
Aggregate coverage report should include sonar-kotlin-test-api
2fbac1b
@Godin
Package name should match containing directory
6eda088
@Godin
SONARKT-394 Upgrade analyzer-commons to 2.12.0
7e34041
@Godin
SONARKT-394 Add STIG metadata
81873d4
@Godin
Upgrade SonarSource/cirrus-modules to v3
ec54954
@leveretka
SONARKT-365 Reduce logging level to info for not supported highlighti…
9cab62c 
…ng in issue messages
@leveretka
WIP migrated regex rules to Analysis API + checked 2.0
55ae5aa
@leveretka
Migrated CipherBlockChainingCheck
3f31a47
@leveretka
Migrated CipherModeOperationCheck
12a51ff
@leveretka
Migrated ClearTextProtocolCheck
c90d8c0
@leveretka
Migrated UnpredictableHashSaltCheck
5c88851
@leveretka
Updated reasons of postponing
3c31cae
@leveretka
SONARKT-357 Enable "NOSONAR" in SonarLint
7833c4c
@leveretka
Migrate DataHashingCheck
b0567b7
@leveretka
Migrate EncryptionAlgorithmCheck
b23293b
@leveretka
Migrate PreparedStatementAndResultSetCheck
f1a2494
@leveretka
Migrate RobustCryptographicKeysCheck
812f9aa
@leveretka
Migrate ReceivingIntentsCheck
4acbe23
@leveretka
Migrate WebViewsFileAccessCheck
b66adab
@leveretka
Migrate WebViewJavaScriptSupportCheck
6081317
@leveretka
Migrate DebugFeatureEnabledCheck
a440388
@Godin Godin force-pushed the margo/rewrite-predict-runtime-value branch from 0b92eb9 to 8f4117e Compare November 27, 2024 14:09
@Godin Godin force-pushed the margo/rewrite-predict-runtime-value branch from 1ff7b3d to 6c4600d Compare November 27, 2024 15:54
@Godin Godin force-pushed the margo/rewrite-predict-runtime-value branch 3 times, most recently from 85476b1 to 71f5ded Compare November 28, 2024 17:08
@Godin Godin force-pushed the margo/rewrite-predict-runtime-value branch from 71f5ded to 436b28f Compare November 28, 2024 18:18
@Godin Godin force-pushed the margo/rewrite-predict-runtime-value branch from 1cfbd22 to ee4ac6f Compare November 29, 2024 21:30
Godin and others added 7 commits December 2, 2024 12:53
@Godin
Remove duplicate test
643b3f7 
VarShouldBeValCheckTest
`with partial semantics`
is duplicate of
`with k1 semantics`.
@Godin
SONARKT-400 Migrate UnusedDeferredResultCheck to kotlin-analysis-api
75018a6
@leveretka @Godin
SONARKT-400 Migrate PropertyGetterAndSetterUsageCheck to kotlin-analy…
7fef2f5 
…sis-api

Co-authored-by: Marharyta Nedzelska <[email protected]>
Co-authored-by: Evgeny Mandrikov <[email protected]>
@leveretka @Godin
SONARKT-400 Migrate DeprecatedCodeCheck to kotlin-analysis-api
cd13463 
Co-authored-by: Marharyta Nedzelska <[email protected]>
Co-authored-by: Evgeny Mandrikov <[email protected]>
@leveretka @Godin
SONARKT-400 Migrate VarShouldBeValCheck to kotlin-analysis-api
48d52ad 
Co-authored-by: Marharyta Nedzelska <[email protected]>
Co-authored-by: Evgeny Mandrikov <[email protected]>
@leveretka @Godin
SONARKT-400 Migrate CoroutineScopeFunSuspendingCheck to kotlin-analys…
ce78158 
…is-api

Co-authored-by: Marharyta Nedzelska <[email protected]>
Co-authored-by: Evgeny Mandrikov <[email protected]>
@Godin
Merge branch 'master'
ac81f7d
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 2, 2024

Quality Gate failed Quality Gate failed

Failed conditions
24 New issues
80.5% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@Godin Godin changed the title kotlin-analysis-api rewrite PoC migration to Kotlin Analysis API Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leveretka @Godin @andrei-epure-sonarsource