Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7154: Fastly API tokens should not be disclosed #4489

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Create rule S7154: Fastly API tokens should not be disclosed #4489

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69daa21
Create rule S7154
loris-s-sonarsource Nov 12, 2024
05643ed
Add text
loris-s-sonarsource Nov 12, 2024
db46b79
Merge branch 'master' into rule/add-RSPEC-S7154
loris-s-sonarsource Nov 12, 2024
c22fb20
Apply suggestions from code review
loris-s-sonarsource Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rules/S7154/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
}
56 changes: 56 additions & 0 deletions rules/S7154/secrets/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{
"title": "Fastly API tokens should not be disclosed",
"type": "VULNERABILITY",
"code": {
"impacts": {
"SECURITY": "HIGH"
},
"attribute": "TRUSTWORTHY"
},
"status": "ready",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "30min"
},
"tags": [
"cwe",
"cert"
],
"defaultSeverity": "Blocker",
"ruleSpecification": "RSPEC-7154",
"sqKey": "S7154",
"scope": "All",
"securityStandards": {
"CWE": [
798,
259
],
"OWASP": [
"A3"
],
"CERT": [
"MSC03-J."
],
"OWASP Top 10 2021": [
"A7"
],
"PCI DSS 3.2": [
"6.5.10"
],
"PCI DSS 4.0": [
"6.2.4"
],
"ASVS 4.0": [
"2.10.4",
"3.5.2",
"6.4.1"
],
"STIG ASD_V5R3": [
"V-222642"
]
},
"defaultQualityProfiles": [
"Sonar way"
],
"quickfix": "unknown"
}
49 changes: 49 additions & 0 deletions rules/S7154/secrets/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@

include::../../../shared_content/secrets/description.adoc[]

== Why is this an issue?

include::../../../shared_content/secrets/rationale.adoc[]

=== What is the potential impact?

API tokens get access to the Fastly API. Tokens can be granted restricted
permissions that limit access to Fastly services and resources, such as

* Load Balancers
* Web Application Firewalls (WAF)
* TLS configuration
* Access Control Lists (ACL)
* etc.

Below are some real-world scenarios that illustrate some impacts of an attacker
exploiting the secret.

:secret_type: API token
loris-s-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

include::../../../shared_content/secrets/impact/data_compromise.adoc[]

include::../../../shared_content/secrets/impact/exceed_rate_limits.adoc[]

include::../../../shared_content/secrets/impact/infrastructure_takeover.adoc[]
loris-s-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

include::../../../shared_content/secrets/impact/malware_distribution.adoc[]

== How to fix it

include::../../../shared_content/secrets/fix/revoke.adoc[]

include::../../../shared_content/secrets/fix/vault.adoc[]
loris-s-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

=== Code examples

:example_secret: 6_v7LZNu9kfidP8MtryE_-X_A9wqGrIx
:example_name: fastly-token
:example_env: FASTLY_TOKEN

include::../../../shared_content/secrets/examples.adoc[]

== Resources

include::../../../shared_content/secrets/resources/standards.adoc[]

Loading