Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-472 Improve instantiation of Analysis classes (Analysis with program or watch program) #4984

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Dec 3, 2024

JS-472

Part of

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Simplify analysis JS-472 Simplify analysis Dec 3, 2024
@zglicz zglicz marked this pull request as ready for review December 3, 2024 11:04
@zglicz zglicz requested review from vdiez, saberduck and ericmorand-sonarsource and removed request for vdiez and saberduck December 3, 2024 11:04
@vdiez vdiez changed the title JS-472 Simplify analysis JS-472 Improve instantiation of Analysis classes (Analysis with program or watch program) Dec 3, 2024
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend that I understand the purpose, but technically and semantically speaking, it looks good to me.

@zglicz zglicz merged commit 6b6eff0 into master Dec 4, 2024
17 of 18 checks passed
@zglicz zglicz deleted the simplify-analysis branch December 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants