Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-469 Remove unused scripts #4970

Merged
merged 1 commit into from
Dec 2, 2024
Merged

JS-469 Remove unused scripts #4970

merged 1 commit into from
Dec 2, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Nov 29, 2024

@vdiez vdiez marked this pull request as ready for review November 29, 2024 15:28
@vdiez vdiez requested a review from zglicz November 29, 2024 15:28
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Remove unused scripts JS-469 Remove unused scripts Nov 29, 2024
@vdiez vdiez force-pushed the remove-unused-scripts branch from 294fed4 to e400e0b Compare November 29, 2024 19:23
Remove unused scripts
@vdiez vdiez force-pushed the remove-unused-scripts branch from 9966740 to 34da3ba Compare November 29, 2024 19:29
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

/**
* Inflate string template with given dictionary
* @param text template string
* @param dictionary object with the keys to replace
*/
export function inflateTemplate(text: string, dictionary: { [x: string]: string }): string {
for (const tok in dictionary) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tok?

@vdiez vdiez merged commit 101d75f into master Dec 2, 2024
18 of 19 checks passed
@vdiez vdiez deleted the remove-unused-scripts branch December 2, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants