Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-421 Fix new-rule script #4969

Merged
merged 3 commits into from
Nov 29, 2024
Merged

JS-421 Fix new-rule script #4969

merged 3 commits into from
Nov 29, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Nov 29, 2024

JS-421

I removed the branch for #4917 by mistake...

  • Refactored the scripts inside tools folder to make use of the same helpers.
    • generate-meta.ts
    • new-rule.ts
    • generate-external-rule-docs.ts
    • generate-rule-indexes.ts
  • The new rule will prompt the user for all needed input (using inquirer.js)
  • Java class will now implement the correct parent class depending if it's a rule for MAIN or TEST
  • All Java check classes have been renamed to use the Sonar rule id. This makes it much easier to synchronize both sides
  • The index with all java checks is now autogenerated on npm ci (as we do in the node.js side) in a git ignored file (AllChecks.java)

@vdiez vdiez marked this pull request as ready for review November 29, 2024 14:54
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
45.7% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

@vdiez vdiez merged commit 17056d6 into master Nov 29, 2024
20 of 22 checks passed
@vdiez vdiez deleted the fix-new-rule branch November 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants