JS-465 Fix typedoc: Migrate to ESM #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
saberduck
force-pushed
the
fix_typedoc
branch
from
94b3752 to
38c8a85
Compare
|
yassin-kammoun-sonarsource
approved these changes
Nov 29, 2024
zglicz
reviewed
Nov 29, 2024
| import url from 'url'; | ||
|
|
||
| // Directory name of the current module | ||
| const __dirname = path.dirname(url.fileURLToPath(import.meta.url)); |
There was a problem hiding this comment.
as we are on node v22, you should also have access to: import.meta.dirname
There was a problem hiding this comment.
this is executed on github actions, I think we only have Node 18 there, so I wanted to stay compatible
There was a problem hiding this comment.
@zglicz I didn't catch that during the review as I was not aware of this new property. Feel free to open a PR and change this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-465