Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-428 Update dependency typescript to v5.7.2 #4940

Merged
merged 4 commits into from
Nov 28, 2024
Merged

JS-428 Update dependency typescript to v5.7.2 #4940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fcf432
Update dependency typescript to v5.7.2
renovate[bot] Nov 28, 2024
593ee04
Fix S3800: typed arrays have different string representation in TS 5.7
saberduck Nov 28, 2024
b7f7c2f
Update ruling test
saberduck Nov 28, 2024
b50ec6c
Fix potentional non-linear regex hotspot
saberduck Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion its/ruling/src/test/expected/jsts/router/javascript-S1874.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
100
],
"router:third_party/brick/brick-1.0.1.byob.js": [
337,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this no longer deprecated?

Copy link
Contributor

@saberduck saberduck Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason, this was removed from TypeScript's DOM types; it's weird. I guess it was very obsolete?

https://github.com/microsoft/TypeScript/pull/60061/files#diff-dc0eab937d15e62545da3ed7b4f40ad6b24f15dd88fbc6ceda2bfb4ed8356eb0L15381

877,
1412,
1637,
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"stylelint": "15.11.0",
"tar": "7.4.3",
"tmp": "0.2.3",
"typescript": "5.6.3",
"typescript": "5.7.2",
"vue-eslint-parser": "9.4.3",
"yaml": "2.6.1"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/jsts/src/rules/S3800/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ function prettyPrint(type: ts.Type, checker: ts.TypeChecker): string {
}

function isTypedArray(type: ts.Type, checker: ts.TypeChecker) {
return checker.typeToString(type).endsWith('Array');
const typeAsString = checker.typeToString(type);
// Since TS 5.7 typed arrays include the type of the elements in the string, eg. Float32Array<any>
return /.*Array(?:<[^>]*>)?$/.test(typeAsString);
}

function isNullLike(type: ts.Type) {
Expand Down