JS-435 Clear dependencies cache when a package.json is modified. #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
vdiez
reviewed
Nov 27, 2024
| @@ -51,7 +51,7 @@ public void analyzeFiles(List<InputFile> inputFiles, List<String> tsConfigs) thr | |||
| progressReport.start(inputFiles.size(), inputFiles.iterator().next().toString()); | |||
| for (InputFile inputFile : inputFiles) { | |||
| var tsConfigFile = tsConfigCache.getTsConfigForInputFile(inputFile); | |||
| analyzeFile(inputFile, tsConfigFile == null ? List.of() : List.of(tsConfigFile.getFilename()), null); | |||
| analyzeFile(inputFile, tsConfigFile == null ? List.of() : List.of(tsConfigFile.getFilename()), null, this.tsConfigCache != null && this.tsConfigCache.getAndResetShouldClearDependenciesCache()); | |||
There was a problem hiding this comment.
the line on top just uses tsConfigCache directly without null checks. Can we just do the same here?
vdiez
approved these changes
Nov 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-435
As it might happen when the package.json is changed, we should dirty the cache.
I've tested, building the jar, copying it into the plugins and verifying that the 2 logs I've added are being triggered. I will add tests once the integration tests for SonarIDE are available.
I've verified, that opening a file from node_modules directory, does not trigger this event: