Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-431 Update S2068 (no-hardcoded-passwords): Adapt documentation to focus only on passwords #4931

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource commented Nov 27, 2024

JS-431

Despite what was discussed on Slack, I decided to adopt the following naming:

  • S2068 -> NoHardcodedPasswordsCheck -> no-hardcoded-passwords
  • S6418 -> NoHardcodedSecretsCheck -> no-hardcoded-secrets

This will align with the title of each rule and what other squads have done.

Please don't forget to review the RPSEC changes.

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title JS-431 Update S2068: Adapt documentation to focus only on passwords JS-431 Update S2068 (no-hardcoded-passwords): Adapt documentation to focus only on passwords Nov 27, 2024
Copy link

sonarqube-next bot commented Nov 27, 2024

Quality Gate failed Quality Gate failed

Failed conditions
87.5% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 2747614 into master Nov 27, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants