JS-363 - Support environment variable for setting skipNodeProvisioning
#4912
Conversation
ericmorand-sonarsource
force-pushed
the
JS-363
branch
2 times, most recently
from
2ffdb3e to
4dfa65f
Compare
|
This is how it looks like in SQ:
|
ericmorand-sonarsource
force-pushed
the
JS-363
branch
3 times, most recently
from
b18b79f to
589ca3a
Compare
| assertThat(propertyDefinition.category()).isEqualTo("JavaScript / TypeScript"); | ||
| assertThat(propertyDefinition.subCategory()).isEqualTo("General"); | ||
| } | ||
|
|
||
| private List<PropertyDefinition> properties() { |
There was a problem hiding this comment.
I took the opportunity to rewrite this utility method using a more declarative and concise syntax.
| * | ||
| * Note that this method should probably not be hosted here: either it should be part of a dedicated helper class, or it should be provided by a Markdown-to-HTML library. Since it is only used in this specific class, it is acceptable for now to have it hosted here. | ||
| */ | ||
| protected String getHTMLMarkup(String markdownMarkup) { |
There was a problem hiding this comment.
why not declare this as private?
There was a problem hiding this comment.
I don't mind, actually, Do you think I should declare the property as private?
There was a problem hiding this comment.
I would say that if you're not using it outside of the class, it might as well be private.
There was a problem hiding this comment.
I changed the visibility to private, but SQ requests me to set is as static. Will do.
| import org.sonar.api.SonarEdition; | ||
| import org.sonar.api.SonarQubeSide; | ||
| import org.sonar.api.SonarRuntime; | ||
| import org.sonar.api.*; |
There was a problem hiding this comment.
I thought we had a rule that forbade to use star imports in java. I don't mind this, just raising this for information.
There was a problem hiding this comment.
I think my IDE did that for me. Let me fix.
EDIT: Actually, it does not seem to trigger an issue, from the quality gate result. Maybe the rule is not in SonarWay anymore?
There was a problem hiding this comment.
WDYT about not using star imports as seems to be the convention? We should somehow enforce it, either with a rule or an IDE config.
There was a problem hiding this comment.
I don't mind. I have no idea what problem using start import could bring.
There was a problem hiding this comment.
This makes sense: https://stackoverflow.com/a/147461
ericmorand-sonarsource
force-pushed
the
JS-363
branch
from
589ca3a to
256fd7b
Compare
|
JS-363