Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-415 Create rule S1291 (no-sonar-comments): Track uses of "NOSONAR" comments #4910

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource commented Nov 18, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Create rule S1291 (no-sonar-comments): Track uses of "NOSONAR" comments JS-415 Create rule S1291 (no-sonar-comments): Track uses of "NOSONAR" comments Nov 18, 2024
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource requested a review from a team November 20, 2024 08:12
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
80.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

@saberduck
Copy link
Contributor

I don't think we can meaningfully achieve higher coverage because of a small number of lines.

@saberduck saberduck merged commit 22ec546 into master Nov 21, 2024
16 of 18 checks passed
@saberduck saberduck deleted the JS-398 branch November 21, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants