Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-381 Update pom parent version #4907

Merged
merged 5 commits into from
Nov 15, 2024
Merged

JS-381 Update pom parent version #4907

merged 5 commits into from
Nov 15, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Nov 15, 2024

JS-381

Based on the releasability, we should update this parent version in the pom

@zglicz zglicz requested a review from a team November 15, 2024 10:48
@zglicz zglicz enabled auto-merge (squash) November 15, 2024 11:37
@zglicz zglicz requested review from saberduck and vdiez November 15, 2024 11:38
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are many files with 2011. why this change? was this done by maven or manually?

@@ -1,6 +1,6 @@
/*
* SonarQube JavaScript Plugin
* Copyright (C) 2011-2024 SonarSource SA
* Copyright (C) 2012-2024 SonarSource SA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 2012?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its consistent across the directory. I could update all the 2012 files to 2011?

Copy link

@zglicz zglicz merged commit 9a3c3ad into master Nov 15, 2024
20 of 21 checks passed
@zglicz zglicz deleted the JS-381-bis branch November 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants