Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-405 Simplify vue parser #4900

Merged
merged 1 commit into from
Nov 12, 2024
Merged

JS-405 Simplify vue parser #4900

merged 1 commit into from
Nov 12, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Nov 12, 2024 •
edited by jira bot
Loading

JS-405

This avoids using a dynamic require internally. Instead, we pass the loaded object that has the "parse" function present.

@zglicz zglicz requested a review from a team November 12, 2024 09:37
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Simplify vue parser JS-405 Simplify vue parser Nov 12, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit 4b15d8f into master Nov 12, 2024
19 of 20 checks passed
@vdiez vdiez deleted the vue-parser branch November 12, 2024 11:20
vdiez pushed a commit that referenced this pull request Nov 14, 2024
@zglicz @vdiez
JS-405 Simplify vue parser (#4900)
74c3a4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zglicz @vdiez