Improve coverage & fix code smells #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned saberduck
|
SonarQube Quality Gate
|
| @@ -151,7 +151,7 @@ public boolean isAvailable() { | |||
| */ | |||
| public void deploy() throws IOException { | |||
| LOG.debug("Detected os: {} arch: {} platform: {}", env.getOsName(), env.getOsArch(), platform); | |||
| if (platform == UNSUPPORTED || isAvailable) { | |||
There was a problem hiding this comment.
should we remove isAvailable altogether?
There was a problem hiding this comment.
isAvailable is needed to know that deployment was successful and embeddednode can be used. We rely on it in NodeCommandBuilder
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned ilia-kebets-sonarsource
ilia-kebets-sonarsource
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM, we can do this change in the feature branch: #4188 (comment)
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned ilia-kebets-sonarsource
ilia-kebets-sonarsource
merged commit ab29cc8
into
feature/bundle-node-runtime-in-analyzer
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #