Cache extracted runtime #4179
Merged
Cache extracted runtime #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ones from target/node
…on it" This reverts commit 4e28738.
Base automatically changed from
fix-slow-tests
to
feature/bundle-node-runtime-in-analyzer
September 18, 2023 21:19
|
TODO:
|
…te it with the environment parameter
...ar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java
Outdated
Show resolved
Hide resolved
...avascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/BridgeServerImplTest.java
Show resolved
Hide resolved
.../sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/EmbeddedNode.java
Show resolved
Hide resolved
...ar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/EmbeddedNodeTest.java
Outdated
Show resolved
Hide resolved
...ar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/EmbeddedNodeTest.java
Outdated
Show resolved
Hide resolved
| @@ -59,7 +60,7 @@ public class NodeCommandBuilderImpl implements NodeCommandBuilder { | |||
| ); | |||
|
|
|||
| private final ProcessWrapper processWrapper; | |||
| private EmbeddedNode embeddedNode = new EmbeddedNode(); | |||
| private EmbeddedNode embeddedNode = new EmbeddedNode(new Environment()); | |||
There was a problem hiding this comment.
verify that
|
SonarQube Quality Gate
|
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned ilia-kebets-sonarsource
saberduck
approved these changes
Sep 20, 2023
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned saberduck
saberduck
merged commit 8b28a90
into
feature/bundle-node-runtime-in-analyzer
15 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.