Add rule S6774 (prop-types): React components should validate prop types
#4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+25
to
+27
| "compatibleLanguages": [ | ||
| "JAVASCRIPT" | ||
| ] |
There was a problem hiding this comment.
Note that I only enabled the rule for JavaScript. I am not convinced it would make sense to enable for TypeScript in general. WDYT?
There was a problem hiding this comment.
I am not sure - the tests include TypeScript: https://github.com/jsx-eslint/eslint-plugin-react/blob/ecadb92609998520be80d64c0bd6bc5e05934aa9/tests/lib/rules/prop-types.js#L1286
On the other hand, it is indeed looks redundant for TypeScript
There was a problem hiding this comment.
Maybe we should try to enable it and see how much noise it makes?
There was a problem hiding this comment.
Tried and noisy, too noisy. Let's keep the rule enabled for JavaScript only.
alex-sonar
approved these changes
Sep 15, 2023
yassin-kammoun-sonarsource
force-pushed
the
i4142
branch
from
c4abd59 to
f4a2bde
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4142