Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMF-2861] Embed Node.js runtime in analyzer #4150

Merged
merged 60 commits into from
Sep 21, 2023
Merged

[MMF-2861] Embed Node.js runtime in analyzer #4150

merged 60 commits into from
Sep 21, 2023

Conversation

saberduck
Copy link
Contributor

No description provided.

saberduck and others added 21 commits August 28, 2023 11:00
@saberduck
Fetch node script - wip
e12532d
@kebetsi
Fetch all distros and support custom target directory
e6933d0
@kebetsi
cleanup
39fa959
@kebetsi
cleanup
617eeb9
@kebetsi
Make destination folders stable
222228d
@kebetsi
use tar gz archives (instead of tar xz) because of lack of support fo…
9f4b3f7 
…r latest node versions
@kebetsi
remove dep
d3cda69
@kebetsi
run script in CI
51f34b4
@kebetsi
fix commands order
a638214
@kebetsi
typo
1564743
@kebetsi
fix path: we can use slashes since it's a URL
31c7196
@kebetsi
don't use array.at() since we're running old nodejs
694f52e
@kebetsi
skip download if file exists, and fix some logs
e09a9e2
@kebetsi
modularize node version
52c02fa
@kebetsi
filter out symlink failing on windows and apply prettier
0fb87d9
@kebetsi
cleanup
3277274
@kebetsi
fix dependency versions
8245ce8
@kebetsi
simplify implementation
69b5cfe
@kebetsi
increase max JAR size to 160MB
555c2e5
@kebetsi
Merge branch 'master' into issue-4116
bf5c499
@ilia-kebets-sonarsource @saberduck
Bunde node: compression (#4126)
8f801a8 
Co-authored-by: Tibor Blenessy <[email protected]>
ilia-kebets-sonarsource
ilia-kebets-sonarsource reviewed Sep 8, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@ilia-kebets-sonarsource ilia-kebets-sonarsource mentioned this pull request Sep 11, 2023
Closed
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after multiple reviews, in this branch and the PRs merged in it, I can say that this feature is good for the master branch!

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again to attempt to trigger "promote" check

@saberduck saberduck enabled auto-merge (squash) September 21, 2023 15:50
@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@saberduck saberduck merged commit cb6d786 into master Sep 21, 2023
13 checks passed
@saberduck saberduck deleted the feature/bundle-node-runtime-in-analyzer branch September 21, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees

@saberduck saberduck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saberduck @ilia-kebets-sonarsource @kebetsi