-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix FP S6749 (
jsx-no-useless-fragment): Ignore empty React fragments
- Loading branch information
1 parent
cb6d786
commit e261284
Showing
7 changed files
with
114 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 0 additions & 37 deletions
37
its/ruling/src/test/expected/ts/eigen/typescript-S6749.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * SonarQube JavaScript Plugin | ||
| * Copyright (C) 2011-2023 SonarSource SA | ||
| * mailto:info AT sonarsource DOT com | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
| // https://sonarsource.github.io/rspec/#/rspec/S6749/javascript | ||
|
|
||
| import { Rule } from 'eslint'; | ||
| import { interceptReport } from '../helpers'; | ||
|
|
||
| /** | ||
| * The core implementation of the rule reports on empty React fragments. | ||
| * Also, one of the two issue messages include a Unicode character. | ||
| */ | ||
| export function decorate(rule: Rule.RuleModule): Rule.RuleModule { | ||
| rule.meta!.hasSuggestions = true; | ||
| rule.meta!.messages = { | ||
| ...rule.meta!.messages, | ||
| /* Map to a more friendly message */ | ||
| NeedsMoreChildren: 'A fragment with only one child is redundant.', | ||
| }; | ||
| return interceptReport(rule, (context, descriptor) => { | ||
| const { messageId, node, ...rest } = descriptor as any; | ||
|
|
||
| /* Ignore empty fragments */ | ||
| if (node.type === 'JSXFragment' && node.children.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| context.report({ messageId, node, ...rest }); | ||
| }); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * SonarQube JavaScript Plugin | ||
| * Copyright (C) 2011-2023 SonarSource SA | ||
| * mailto:info AT sonarsource DOT com | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
| import { rules } from 'eslint-plugin-react'; | ||
| import { decorate } from './decorator'; | ||
|
|
||
| export const rule = decorate(rules['jsx-no-useless-fragment']); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * SonarQube JavaScript Plugin | ||
| * Copyright (C) 2011-2023 SonarSource SA | ||
| * mailto:info AT sonarsource DOT com | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
| import { RuleTester } from 'eslint'; | ||
| import { rule } from './'; | ||
|
|
||
| const ruleTester = new RuleTester({ | ||
| parserOptions: { ecmaVersion: 2018, ecmaFeatures: { jsx: true } }, | ||
| }); | ||
| ruleTester.run('Redundant React fragments should be removed', rule, { | ||
| valid: [ | ||
| { | ||
| code: `function Empty() { return <></>; }`, | ||
| }, | ||
| ], | ||
| invalid: [ | ||
| { | ||
| code: `function Child() { return <><img /></>; }`, | ||
| output: `function Child() { return <img />; }`, | ||
| errors: [ | ||
| { | ||
| message: 'A fragment with only one child is redundant.', | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters