Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CAU validation fixes #106

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Fix: CAU validation fixes #106

merged 15 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. ⚡️ Bye Google Analytics 

    Don't track users with GA if we are using Plausible.
Besides 1% 10K of gzip payload reduced.
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b900939 View commit details
    Browse the repository at this point in the history

  2. 📝 changes

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5a6e2d4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'IMP_bye_google_analytics'

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cdc7d58 View commit details
    Browse the repository at this point in the history

  4. 🐛 warning: no component body1 

    indeed body1 variant was too big used proper variant
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0edc148 View commit details
    Browse the repository at this point in the history

  5. ♻️ extracted CAU inputFilter as prettyCAU in utils

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f56e5aa View commit details
    Browse the repository at this point in the history

  6. 🐛 API validated: when validating issuing such 'error'

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a5c0940 View commit details
    Browse the repository at this point in the history

  7. 🐛 ApiValidated: descending pretty version 

    Even though we bubble up compact version,
if we push down pretty version, the input
will understand it as a change of the value,
and will repeat the check. In some cases
even creating an infinite loop.
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    13cd751 View commit details
    Browse the repository at this point in the history

  8. 🐛 removed warning, error is boolean not string

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    812846d View commit details
    Browse the repository at this point in the history

  9. 🐛 the validation progress and check didn't appear

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8dd2034 View commit details
    Browse the repository at this point in the history

  10. 🐛 discriminate 'required' and 'initial' message 

    Initial message (explaining where to find the CAU)
was not shown initially, just the required error
'CAU must be filled'.
Now the required error is shown only after
the field has been visited.
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6a0f258 View commit details
    Browse the repository at this point in the history

  11. 🐛 remote checking compact and not pretty CAU 

    This was the root of the remaining validation infinite loop.
The validator took the pretty value and so formik sent it
back to the input which was detected as different and
thus validated again.

Previous fixes just avoided this on other cases.
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bdb63f9 View commit details
    Browse the repository at this point in the history

  12. ♻️ explicitly naming for compact or pretty values 

    This might avoid falling again confusions and errors.
They are not all the same value. What we receive from
and send to the outside world is a compact value,
what we edit in the widget is a pretty value
(with spaces and decoration).

(pretty and compact is python stdnum library nomenclature)
    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e5aaa5c View commit details
    Browse the repository at this point in the history

  13. 📝 ApiValidatedField: documented known bugs

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    517ea35 View commit details
    Browse the repository at this point in the history

  14. 📝 changes

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2e52f64 View commit details
    Browse the repository at this point in the history

  15. 🐛 fix variable misspel

    @vokimon
    vokimon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    39d08dc View commit details
    Browse the repository at this point in the history