Run solace container with a non-root user for podman compatibility #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user gets ownership of the /var/lib/solace directory
SravanThotakura05
approved these changes
Feb 15, 2024
|
@ozangunalp can we merge this PR? |
|
Yes, if that's ok for you |
| @@ -245,6 +242,11 @@ protected void configure() { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| protected void containerIsStarted(InspectContainerResponse containerInfo) { | |||
| executeCommand("chown 1000:0 -R /var/lib/solace"); | |||
There was a problem hiding this comment.
@ozangunalp I am just going through logs before merging it looks like this command fails. In the docs it mentions that we need to set the permission to source folder. I think we can remove it
There was a problem hiding this comment.
I did a quick run on my local by enabling podman, and i didnt see any major issue while using dev container/running tests(Saw same error in log while running tests). Let's merge this now and if any unexpected issue crops up will address in next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user gets ownership of the
/var/lib/solacedirectoryShould fix #55
For info with podman I can run a Solace container with the following command:
podman run --rm -it -u 1000 -p 8080:8080 -p 55555 --shm-size=1g \ --env username_admin_globalaccesslevel=admin \ --env username_admin_password=admin \ --mount type=tmpfs,destination=/var/lib/solace,ro=false,U=true \ docker.io/solace/solace-pubsub-standard:latest