Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The "Unsaved Changes Dialog" pops up, but the content display section is empty. #7482

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

womendoushihaoyin
Copy link
Contributor

When I switch printers from the left tab bar, Orca checks if there have been any modifications relative to the system presets. If there are changes, it pops up the Unsaved Changes Dialog.
But sometimes I find that the change content display section in the dialog is empty. This is undoubtedly very confusing for users.
Upon investigation, it was found that this confusion arises because when comparing the initial preset with the current preset, there are some attributes that have not been changed, but the comparison still shows them as different. However, these attributes cannot be displayed in the dialog box (for example, the attribute long_retraction_when_cut).
So, I've made the size of m_presetitems the criterion for whether to pop up the dialog box or not, because what is actually displayed in the table is the content of m_presetitems. If the size of m_presetitems is 0, then the dialog box is skipped directly, and it is treated as if the changes were discarded.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice QoL fix
Thank you!

@SoftFever SoftFever merged commit 2a61cea into SoftFever:main Nov 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants