Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOREVIEW]All test ok #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 43 additions & 26 deletions LabJavaIO/src/main/java/ch/heigvd/res/labio/impl/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@
import ch.heigvd.res.labio.interfaces.IFileVisitor;
import ch.heigvd.res.labio.quotes.QuoteClient;
import ch.heigvd.res.labio.quotes.Quote;
import java.io.File;
import java.io.IOException;
import java.io.StringWriter;
import java.io.Writer;

import java.io.*;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.apache.commons.io.FileUtils;
Expand All @@ -26,52 +24,52 @@ public class Application implements IApplication {
* to where the Java application is invoked.
*/
public static String WORKSPACE_DIRECTORY = "./workspace/quotes";

private static final Logger LOG = Logger.getLogger(Application.class.getName());

public static void main(String[] args) {

/*
* I prefer to have LOG output on a single line, it's easier to read. Being able
* to change the formatting of console outputs is one of the reasons why it is
* better to use a Logger rather than using System.out.println
*/
System.setProperty("java.util.logging.SimpleFormatter.format", "%4$s: %5$s%6$s%n");


int numberOfQuotes = 0;
try {
numberOfQuotes = Integer.parseInt(args[0]);
} catch (Exception e) {
System.err.println("The command accepts a single numeric argument (number of quotes to fetch)");
System.exit(-1);
}

Application app = new Application();
try {
/*
* Step 1 : clear the output directory
*/
app.clearOutputDirectory();

/*
* Step 2 : use the QuotesClient to fetch quotes; store each quote in a file
*/
app.fetchAndStoreQuotes(numberOfQuotes);

/*
* Step 3 : use a file explorer to traverse the file system; print the name of each directory and file
*/
Writer writer = new StringWriter(); // we create a special writer that will send characters into a string (memory)
app.printFileNames(writer); // we hand over this writer to the printFileNames method
LOG.info(writer.toString()); // we dump the whole result on the console

/*
* Step 4 : process the quote files, by applying 2 transformations to their content
* (convert to uppercase and add line numbers)
*/
app.processQuoteFiles();

} catch (IOException ex) {
LOG.log(Level.SEVERE, "Could not fetch quotes. {0}", ex.getMessage());
ex.printStackTrace();
Expand All @@ -90,42 +88,56 @@ public void fetchAndStoreQuotes(int numberOfQuotes) throws IOException {
* one method provided by this class, which is responsible for storing the content of the
* quote in a text file (and for generating the directories based on the tags).
*/
storeQuote(quote,"quote-"+quote.getValue().getId());
LOG.info("Received a new joke with " + quote.getTags().size() + " tags.");
for (String tag : quote.getTags()) {
LOG.info("> " + tag);
}
}
}

/**
* This method deletes the WORKSPACE_DIRECTORY and its content. It uses the
* apache commons-io library. You should call this method in the main method.
*
* @throws IOException
*
* @throws IOException
*/
void clearOutputDirectory() throws IOException {
FileUtils.deleteDirectory(new File(WORKSPACE_DIRECTORY));
FileUtils.deleteDirectory(new File(WORKSPACE_DIRECTORY));
}

/**
* This method stores the content of a quote in the local file system. It has
* 2 responsibilities:
*
* 2 responsibilities:
*
* - with quote.getTags(), it gets a list of tags and uses
* it to create sub-folders (for instance, if a quote has three tags "A", "B" and
* "C", it will be stored in /quotes/A/B/C/quotes-n.utf8.
*
*
* - with quote.getQuote(), it has access to the text of the quote. It stores
* this text in UTF-8 file.
*
*
* @param quote the quote object, with tags and text
* @param filename the name of the file to create and where to store the quote text
* @throws IOException
* @throws IOException
*/
void storeQuote(Quote quote, String filename) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
String path = WORKSPACE_DIRECTORY + "/";
for(String c : quote.getTags()){
path += c +"/";
}
File newDir = new File(path);
newDir.mkdirs();

path += filename +".utf8";

File newFile = new File(path);
newFile.createNewFile();
FileOutputStream writeFile = new FileOutputStream(newFile);
writeFile.write((quote.getQuote().getBytes()));
writeFile.close();
}

/**
* This method uses a IFileExplorer to explore the file system and prints the name of each
* encountered file and directory.
Expand All @@ -140,14 +152,19 @@ public void visit(File file) {
* of the the IFileVisitor interface inline. You just have to add the body of the visit method, which should
* be pretty easy (we want to write the filename, including the path, to the writer passed in argument).
*/
try {
writer.write(file.getPath()+"\n");
} catch (IOException exception){
System.err.println("Error in file visit");
}
}
});
}

@Override
public void processQuoteFiles() throws IOException {
IFileExplorer explorer = new DFSFileExplorer();
explorer.explore(new File(WORKSPACE_DIRECTORY), new CompleteFileTransformer());
explorer.explore(new File(WORKSPACE_DIRECTORY), new CompleteFileTransformer());
}

}
25 changes: 23 additions & 2 deletions LabJavaIO/src/main/java/ch/heigvd/res/labio/impl/Utils.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,28 @@ public class Utils {
* contain any line separator, then the first element is an empty string.
*/
public static String[] getNextLine(String lines) {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
String[] result = new String[2];
result[0] = "";
result[1] = "";
boolean isWindowsNewLine = false;
boolean nextLineOk = false;
for(int i = 0; i < lines.length();i++){
if(nextLineOk) {
result[1] += lines.charAt(i);
}else{
result[0] += lines.charAt(i);
if(lines.charAt(i) == '\n'){
nextLineOk = true;
}
if(lines.charAt(i) == '\r' && ((i+1 < lines.length())&&(lines.charAt(i+1)!= '\n')||(i == lines.length()-1))){
nextLineOk = true;
}
}
}
if(nextLineOk == false){
result[1] = result[0];
result[0] = "";
}
return result;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
import ch.heigvd.res.labio.interfaces.IFileExplorer;
import ch.heigvd.res.labio.interfaces.IFileVisitor;
import java.io.File;
import java.lang.reflect.Array;
import java.util.Arrays;
import java.util.Objects;

/**
* This implementation of the IFileExplorer interface performs a depth-first
Expand All @@ -16,7 +19,14 @@ public class DFSFileExplorer implements IFileExplorer {

@Override
public void explore(File rootDirectory, IFileVisitor vistor) {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
vistor.visit(rootDirectory);
if(!rootDirectory.isDirectory()){
return;
}
File[] files = Objects.requireNonNull(rootDirectory.listFiles());
Arrays.sort(files);
for(File file : files) {
explore(file, vistor);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,44 @@
public class FileNumberingFilterWriter extends FilterWriter {

private static final Logger LOG = Logger.getLogger(FileNumberingFilterWriter.class.getName());

int nbLine = 1;
boolean isNewLine = true;
boolean isWindowsNewLine = false;
public FileNumberingFilterWriter(Writer out) {
super(out);
}

@Override
public void write(String str, int off, int len) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
write(str.toCharArray(),off,len);
}

@Override
public void write(char[] cbuf, int off, int len) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
for(int i = 0; i<len;i++){
write(cbuf[off + i]);
}
}

@Override
public void write(int c) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
boolean alreadyWrite = false;
if(isWindowsNewLine && c != '\n')
isWindowsNewLine =false;
if(c == '\n' || c== '\r'){
alreadyWrite = true;
super.write(c);
isNewLine = true;
if(c == '\r')
isWindowsNewLine = true;
}
if(isNewLine && !isWindowsNewLine){
for (char charNbLine : String.valueOf(nbLine++).toCharArray())
super.write(charNbLine);
super.write('\t');
isNewLine = false;
}
if(!alreadyWrite)
super.write(c);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,20 @@ public UpperCaseFilterWriter(Writer wrappedWriter) {

@Override
public void write(String str, int off, int len) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
write(str.toCharArray(),off, len);
}

@Override
public void write(char[] cbuf, int off, int len) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
for (int i = 0 ; i < len ;i++){
write(cbuf[off+i]);
}
}

@Override
public void write(int c) throws IOException {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
if (Character.isLowerCase(c))
c = Character.toUpperCase(c);
super.write(c);
}

}
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package ch.heigvd.res.labio.impl.transformers;

import ch.heigvd.res.labio.impl.filters.FileNumberingFilterWriter;
import ch.heigvd.res.labio.impl.filters.UpperCaseFilterWriter;

import java.io.Writer;

/**
Expand All @@ -15,16 +18,13 @@ public class CompleteFileTransformer extends FileTransformer {

@Override
public Writer decorateWithFilters(Writer writer) {
if (true) {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
}
/*
* If you uncomment the following line (and get rid of th 3 previous lines...), you will restore the decoration
* of the writer (connected to the file. You can see that you first decorate the writer with an UpperCaseFilterWriter, which you then
* decorate with a FileNumberingFilterWriter. The resulting writer is used by the abstract class to write the characters read from the
* input files. So, the input is first prefixed with line numbers, then transformed to uppercase, then sent to the output file.f
*/
//writer = new FileNumberingFilterWriter(new UpperCaseFilterWriter(writer));
writer = new FileNumberingFilterWriter(new UpperCaseFilterWriter(writer));
return writer;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ public void visit(File file) {
* writer has been decorated by the concrete subclass!). You need to write a loop to read the
* characters and write them to the writer.
*/
int c =reader.read();
while(c != -1){
writer.write(c);
c = reader.read();
}

reader.close();
writer.flush();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,13 @@ public class NoOpFileTransformer extends FileTransformer {

@Override
public Writer decorateWithFilters(Writer writer) {
throw new UnsupportedOperationException("The student has not implemented this method yet.");
/*
/*
* The NoOpFileTransformer does not apply any transformation of the character stream
* (no uppercase, no line number, etc.). So, we don't need to decorate the writer connected to
* the output file at all. Just uncomment the following line and get rid of the UnsupportedOperationException and
* you will be all set.
*/
//return writer;
return writer;
}

}