-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlays and the Ingame API #836
base: master
Are you sure you want to change the base?
Overlays and the Ingame API #836
Conversation
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 74.43% 74.11% -0.33%
==========================================
Files 546 548 +2
Lines 16935 16989 +54
==========================================
- Hits 12606 12591 -15
- Misses 4329 4398 +69 |
…e unique browsers
…or now until we set up input hooking to IPC.
looking at rewriting the ingame component in Rust for single-assembly injection. marshalling right now between native and managed context is a mess to say the least |
Might more sense as a standalone library in Rust here. We do a lot of hacky shit so this definitely won't be safe Rust but if at all possible a single-dll injection is preferable to chainloading the CLR |
SnowflakePowered/snowflake-ingame@fec8172 fully implements dx11 and ogl rendering. Can remove inject dll from project |
TextureHandle = this.SharedTextureHandle, | ||
Width = this.TargetTextureDescription.Width, | ||
Height = this.TargetTextureDescription.Height, | ||
Size = this.TargetTextureDescription.Width * this.TargetTextureDescription.Height * CEFBufferBPP * 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess its not (width * height * 4) * 2
but (pitch * height * 4)
since you're backing gl texture with dx texture, you may take into account the stride to get valid size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
further a lot more of investigation, it turns out a value of 0 will map the resource according to its internal size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much! I’ll continue to work on this once I sort out vulkan for the snowflake-ingame side
Ingame Pipe ABI
Todo