Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update docs and migration guide #3313

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Dec 20, 2024

  • Update docs and migration guide
  • Bump tracking version
  • Fix method usage after merge (method has been removed)
  • Fix whitespace
  • Fix link
  • Improve function and procedure examples (multiline)

References: #3303 #3302 #3298

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review December 20, 2024 14:04
Copy link

Integration tests cancelled for feda5f2d9c470487de7c928f0f73cfd570ec3f8a

@@ -31,13 +31,13 @@ resource "snowflake_function_scala" "complete" {
}
comment = "some comment"
external_access_integrations = ["external_access_integration_name", "external_access_integration_name_2"]
function_definition = <<EOF
function_definition = <<EOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We should address this later, but we use both EOF and EOT in different files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that now we only have EOT (do you see any files with EOF?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Masking policy example and acc test.

MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki merged commit 655d0e5 into dev Dec 20, 2024
6 of 8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the update-docs-and-migration-guide branch December 20, 2024 14:15
sfc-gh-asawicki added a commit that referenced this pull request Dec 20, 2024
- Update docs and migration guide
- Bump tracking version
- Fix method usage after merge (method has been removed)
- Fix whitespace
- Fix link
- Improve function and procedure examples (multiline)

References: #3303 #3302 #3298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants