Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjust test asserts #3289

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

chore: Adjust test asserts #3289

wants to merge 3 commits into from

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

TBD

@github-actions GitHub Actions
Copy link

Integration tests failure for 53a5058de2ca863dbf9255bc4f07d796f9e795b9

sfc-gh-asawicki
sfc-gh-asawicki reviewed Dec 18, 2024
View reviewed changes
pkg/acceptance/bettertestspoc/assert/resourceassert/account_resource_gen.go
// Attribute empty checks //
////////////////////////////

func (a *AccountResourceAssert) HasAdminNameEmpty() *AccountResourceAssert {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's filter out the needed messages by the "required" attribute in schema - e.g. this can never be empty, so this assertion should not be generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki