Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get datasource tables on par with views #3249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hpors
Copy link

@hpors hpors commented Dec 5, 2024

When using the terraform plugin we've got hindered by the discrepancy between the datasources views and tables. It seems the datasource views has already been further developed than tables. In the roadmap it is stated that the redesign for snowflake_tables is in progress, but for us this is a blocking issue, hence this MR.
The goal of this MR is to add the new functionalities of the views datasource to tables as well.

Test Plan

  • acceptance tests for changed datasource Tables have been changed
  • integration tests for tables have been changed as filter types have been added and changed

References

@hpors hpors force-pushed the feat-update-datasource-tables branch from f5d1feb to 21132a8 Compare December 5, 2024 09:54
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 5, 2024 10:31
@sfc-gh-asawicki
Copy link
Collaborator

Hey @hpors. Thanks for contributing the the project.

Tables are being reworked currently, and their schemas may change significantly. We usually leave datasources as the last thing to do in the rework because only then do we have the proper schemas for them and it allows us to enforce just one migration when the object is fully reworked. Because of that I wouldn't merge these changes right now.

We can leave this PR open and may use it or parts of it when we have the table object fully reworked. Does that sound okay to you?

@hpors
Copy link
Author

hpors commented Dec 5, 2024

hi @sfc-gh-asawicki, thank you for the feedback.

I understand the reasoning behind leaving the datasources until the end of the rework. I am okay with leaving this PR open and potentially using it later.

Is there any indication of the timeline for when the table object rework might be completed?

@sfc-gh-asawicki
Copy link
Collaborator

After concluding functions, procedures, accounts, and unsafe execute - tables will become our top priority object to finish its rework. It is probably the "biggest" object, and Christmas Holidays are coming, so I would estimate that tables should be finished before the end of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants