Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add usage tracking for the rest of the resources and fix views #3223

Merged
merged 3 commits into from
Nov 26, 2024
Merged

chore: Add usage tracking for the rest of the resources and fix views #3223

merged 3 commits into from
Nov 26, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Nov 25, 2024 •
edited
Loading

Changes

  • Add usage tracking to the remaining resources (had to change their method signature to the new one containing context)
  • Fix views (trimmed the tracking comment from the text column that contains the command run to create the view)
    • Applied the same fix for materialized view and dynamic table that also contain self reference to create command

sfc-gh-jmichalak
sfc-gh-jmichalak previously approved these changes Nov 25, 2024
View reviewed changes
pkg/internal/tracking/query_test.go Show resolved Hide resolved
pkg/internal/tracking/query_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 560db4402c181c0aec7ccc90392e309a27e7b0a3

@github-actions GitHub Actions
Copy link

Integration tests failure for 7fa077a1e608e17863b36d2896724b995f201c8d

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 25, 2024
View reviewed changes
pkg/resources/oauth_integration_test.go Outdated Show resolved Hide resolved
pkg/resources/saml_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/dynamic_table.go Outdated Show resolved Hide resolved
pkg/sdk/views_impl_gen.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests cancelled for ce62a25ca0442ae153db285528eb49a88cba845d

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the basic-object-tracking-part3 branch from ce62a25 to 212275d Compare November 26, 2024 09:43
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the basic-object-tracking-part3 branch from 212275d to 857647d Compare November 26, 2024 09:53
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 26, 2024 13:08
@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this pull request Nov 26, 2024
Merged
2 tasks
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 231f653 into main Nov 26, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the basic-object-tracking-part3 branch November 26, 2024 13:20
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 26, 2024
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 26, 2024
@snowflake-release-please
chore(main): release 0.99.0 (#3201)
57c0c2c 
🤖 I have created a release *beep* *boop*
---


##
[0.99.0](v0.98.0...v0.99.0)
(2024-11-26)


### 🎉 **What's new:**

* Add tags data source
([#3211](#3211))
([8907d9d](8907d9d))
* Tag resource v1
([#3197](#3197))
([77b3bf0](77b3bf0))
* Tasks v1 readiness
([#3222](#3222))
([e2284d9](e2284d9))


### 🔧 **Misc**

* Add support for usage tracking to data sources
([#3224](#3224))
([8210bb8](8210bb8))
* Add usage tracking for the rest of the resources and fix views
([#3223](#3223))
([231f653](231f653))
* Basic object tracking
([#3205](#3205))
([1f0dc94](1f0dc94))
* basic object tracking part 2
([#3214](#3214))
([e44f2e1](e44f2e1))
* Improve tags integration tests
([#3193](#3193))
([7736e0a](7736e0a))
* parser and secret tests
([#3192](#3192))
([5ec9c86](5ec9c86))
* Storage integration with custom protocol
([#3213](#3213))
([a3a44ae](a3a44ae))
* Unskip auth config tests
([#3180](#3180))
([46ab142](46ab142))


### 🐛 **Bug fixes:**

* Small fixes and adjustments
([#3226](#3226))
([9f67457](9f67457))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak