feat: Task datasource and fixes #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for ed1251592b98654e893e6603f4492bdfdad5b3c3 |
|
Integration tests failure for 4ba347973ed7175e8ca566d67653229a1e6619d2 |
sfc-gh-asawicki
requested changes
Nov 14, 2024
sfc-gh-jmichalak
requested changes
Nov 15, 2024
pkg/acceptance/bettertestspoc/assert/resourceshowoutputassert/user_show_output_ext.go
Outdated
Show resolved
Hide resolved
…-fixes # Conflicts: # pkg/datasources/tasks_acceptance_test.go # pkg/resources/task_acceptance_test.go
|
Integration tests failure for 584a3ca350378be7ea5893e2bd2aca4ccb89ad88 |
sfc-gh-jmichalak
approved these changes
Nov 18, 2024
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: true, | ||
| Description: "Runs SHOW PARAMETERS FOR TASK for each user returned by SHOW TASK. The output of describe is saved to the parameters field as a map. By default this value is set to true.", |
There was a problem hiding this comment.
Shouldn't it be for each task? Also, get rid of describe in the second sentence, as it's confusing with DESCRIBE.
There was a problem hiding this comment.
Addressed in: #3202
sfc-gh-asawicki
approved these changes
Nov 18, 2024
| } | ||
| *setField = &sdk.In{Schema: schemaId} |
There was a problem hiding this comment.
nit (next PR): default return err?
There was a problem hiding this comment.
Addressed in: #3202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
configwith $$infilteringList from previous prs
asfield) - feat: Task resource v1 readiness #3113 (comment)