fix: Fix grant import docs #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sfc-gh-asawicki
commented
Nov 8, 2024
•
sfc-gh-asawicki
commented
- Update references on V1 resources lists
- Updated state of resources
- Bumped version to v0.98.0
- Fix data sources links
- Update essential/remaining resources lists
- Fix grants docs (References Whats the new import statement for role_grants? #3179)
- Add V1 release candidate info
- Add resource to all import commands
- Use single quotes in import examples
|
Integration tests cancelled for e92cb4f0bc2bc34da0ec22f098aaab443fd618f5 |
sfc-gh-jmichalak
previously approved these changes
Nov 8, 2024
| | APPLICATION | ❌ | - | | ||
| | APPLICATION PACKAGE | ❌ | - | | ||
| | APPLICATION ROLE | ❌ | [#3134](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3134) - | | ||
| | CONNECTION | 🚀 | - | |
There was a problem hiding this comment.
Nit: there are some trailing spaces. Do we have a ticket for introducing a markdown formatter/linter?
There was a problem hiding this comment.
These trailing spaces allows jetbrains ides to display the md tables correctly, they were added on purpose
| * [snowflake_tags](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/0.97.0/docs/data-sources/tags) (datasource) | ||
| * [snowflake_tag](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/0.98.0/docs/resources/tag) | ||
| * [snowflake_tag_association](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/0.98.0/docs/resources/tag_association) | ||
| * [snowflake_tags](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/0.98.0/docs/data-sources/tags) (datasource) |
There was a problem hiding this comment.
Why not just latest? Are we going to update this file with each release?
There was a problem hiding this comment.
because we have no control over the latest; also, after the V1 release, the latest will point to the 1.x.x versions, and I think this should point to the exact release candidates.
|
Integration tests cancelled for 8d56b93289b52ffae6bb8e1af83f8e98617f241d |
sfc-gh-jcieslak
approved these changes
Nov 8, 2024
sfc-gh-jmichalak
approved these changes
Nov 8, 2024
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Nov 8, 2024
## [0.98.0](v0.97.0...v0.98.0) (2024-11-08) Feature scope readiness for V1: [link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)). :exclamation: Migration guide: [v0.97.0 -> v0.98.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980) ### 🎉 What's new - New resources: - authentication_policy ([#3098](#3098)), references [#2880](#2880) - external_volume ([#3106](#3106)), partially references [#2980](#2980) - stream_on_directory_table ([#3129](#3129)) - stream_on_view ([#3150](#3150)) - primary_connection, secondary_connection ([#3162](#3162)) - secret_with_basic_authentication, secret_with_generic_string, secret_with_oauth_authorization_code_grant, secret_with_oauth_client_credentials ([#3110](#3110)), ([#3141](#3141)) - New data sources: - connections ([#3155](#3155)), ([#3173](#3173)) - secrets ([#3131](#3131)) - Reworked: - provider configuration hierarchy ([#3166](#3166)), references [#1881](#1881), [#2145](#2145), [#2925](#2925), [#2983](#2983), [#3104](#3104) - provider configuration fields ([#3152](#3152)) streams data source ([#3151](#3151)) - SDK upgrades: - Upgrade tag SDK ([#3126](#3126)) - Recreate streams when they are stale ([#3129](#3129)) ### 🔧 Misc - Add object renaming research summary ([#3172](#3172)) - Test support for object renaming ([#3130](#3130)), ([#3147](#3147)), ([#3154](#3154)) - Add tests to issue [#3117](#3117) ([#3133](#3133)) - New roadmap entry ([#3158](#3158)) - Test more authentication methods ([#3178](#3178)) - Minor fixes ([#3174](#3174)) ### 🐛 Bug fixes - Apply various fixes ([#3176](#3176)), this addresses BCR 2024_08, references [#2717](#2717), [#3005](#3005), [#3125](#3125), [#3127](#3127), [#3153](#3153) - Connection and secret data sources tests ([#3177](#3177)) - Fix grant import docs ([#3183](#3183)), resolves [#3179](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179) - Fix user resource import ([#3181](#3181)) - Handle external type changes in stream resources ([#3164](#3164)) - Do not use OR REPLACE on initial creation in resources with copy_grants ([#3129](#3129)) - Address issue [#2201](#2201) by introducing new stream resources Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.