Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Unskip auth config tests #3180

Merged
merged 13 commits into from
Nov 18, 2024
Merged

chore: Unskip auth config tests #3180

merged 13 commits into from
Nov 18, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Nov 7, 2024 •
edited
Loading

  • add a new v097-compatible config file
  • unskip auth related tests
  • for older providers, set the config file to be v097-compatible

Test Plan

  • acceptance tests
  • …

TODO (next pr)

  • read from the proper secrets and remove temporary secrets

@sfc-gh-jmichalak sfc-gh-jmichalak changed the title chore: Unskip config tests chore: Unskip auth config tests Nov 7, 2024
@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this pull request Nov 7, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests failure for 804067caaee304b1c58d670259eba1b6072de0ac

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests cancelled for 804067caaee304b1c58d670259eba1b6072de0ac

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests failure for ddffa2ecc41d5ccce7c562d41b6bba749dd593eb

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests failure for 34c116c2c82a506f086829ff7119ab2f0e838abb

sfc-gh-jmichalak added a commit that referenced this pull request Nov 8, 2024
@sfc-gh-jmichalak
chore: Test more authentication methods (#3178)
d345cd2 
<!-- Feel free to delete comments as you fill this in -->
- add a test for JWT authentication (skipped for now; it needs a
configuration adjustment and this will be done in [the next
PR](#3180))
- add a test for Okta
- add a test for session parameters
- move driver log level to sdk
- add tests for Mfa with and without passcode
- fix conflicting fields in view resource
- bring back configuring logging level for internal client tests
- describe all of the manual test steps in a readme
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## TODO
<!-- issues documentation links, etc  -->
- [(next
pr)](#3180)
read a compatible config file for older versions in acc tests, adjust
the configurations in Github secrets and our secret storage, and unskip
the relevant tests
- Other authentication methods will be done in SNOW-1791729.
Base automatically changed from config-rework to main November 8, 2024 12:25
@sfc-gh-jmichalak sfc-gh-jmichalak requested review from sfc-gh-asawicki and sfc-gh-jcieslak and removed request for sfc-gh-asawicki November 8, 2024 12:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Integration tests cancelled for 8dad7c5538a1f79bc5d91c07b21989ef52749071

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review November 8, 2024 12:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Integration tests cancelled for 8d59be77692a24935a49e8d9113e745b8ca110dd

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Integration tests failure for 5430143fffb781ee79345473212ff1060d48021f

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 tests with external providers that were added in the meantime and failed in your pipeline, please update them too.

.github/workflows/tests.yml Show resolved Hide resolved
pkg/acceptance/testing.go Outdated Show resolved Hide resolved
sfc-gh-jcieslak
sfc-gh-jcieslak previously approved these changes Nov 14, 2024
View reviewed changes
pkg/acceptance/testing.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for ee5104b67cb192f8f5390083b1d3a516cb24004a

@github-actions GitHub Actions
Copy link

Integration tests failure for 795279c3196b608f4d9858163b22309873e69280

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 18, 2024 11:15
sfc-gh-asawicki
sfc-gh-asawicki approved these changes Nov 18, 2024
View reviewed changes
pkg/resources/network_policy_acceptance_test.go
@@ -479,7 +479,7 @@ func TestAcc_NetworkPolicy_Issue2236(t *testing.T) {
// Identifier quoting mismatch (no diff suppression)
ExpectNonEmptyPlan: true,
PreConfig: func() {
acc.SetV097CompatibleConfigPathEnv(t)()
func() { acc.SetV097CompatibleConfigPathEnv(t) }()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (next PR): you don't have to wrap here

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration tests pipeline is failing (please check it)

@github-actions GitHub Actions
Copy link

Integration tests failure for 35194ca617966252b6725b18bf2cd528c4667d6c

3 similar comments
@github-actions GitHub Actions
Copy link

Integration tests failure for 35194ca617966252b6725b18bf2cd528c4667d6c

@github-actions GitHub Actions
Copy link

Integration tests failure for 35194ca617966252b6725b18bf2cd528c4667d6c

@github-actions GitHub Actions
Copy link

Integration tests failure for 35194ca617966252b6725b18bf2cd528c4667d6c

@github-actions GitHub Actions
Copy link

Integration tests failure for 35194ca617966252b6725b18bf2cd528c4667d6c

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 06d6ac3b09f999c2b194efa46d09824507927a57

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 4736dc6958fe86ca7f85ffa58df1242e32585efe

@github-actions GitHub Actions
Copy link

Integration tests failure for 81bd6c0c33004e2b1b911c08f6d383841b468ff6

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 18, 2024 15:34
@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 46ab142 into main Nov 18, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the unskip-config-tests branch November 18, 2024 15:37
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 18, 2024
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 26, 2024
@snowflake-release-please
chore(main): release 0.99.0 (#3201)
57c0c2c 
🤖 I have created a release *beep* *boop*
---


##
[0.99.0](v0.98.0...v0.99.0)
(2024-11-26)


### 🎉 **What's new:**

* Add tags data source
([#3211](#3211))
([8907d9d](8907d9d))
* Tag resource v1
([#3197](#3197))
([77b3bf0](77b3bf0))
* Tasks v1 readiness
([#3222](#3222))
([e2284d9](e2284d9))


### 🔧 **Misc**

* Add support for usage tracking to data sources
([#3224](#3224))
([8210bb8](8210bb8))
* Add usage tracking for the rest of the resources and fix views
([#3223](#3223))
([231f653](231f653))
* Basic object tracking
([#3205](#3205))
([1f0dc94](1f0dc94))
* basic object tracking part 2
([#3214](#3214))
([e44f2e1](e44f2e1))
* Improve tags integration tests
([#3193](#3193))
([7736e0a](7736e0a))
* parser and secret tests
([#3192](#3192))
([5ec9c86](5ec9c86))
* Storage integration with custom protocol
([#3213](#3213))
([a3a44ae](a3a44ae))
* Unskip auth config tests
([#3180](#3180))
([46ab142](46ab142))


### 🐛 **Bug fixes:**

* Small fixes and adjustments
([#3226](#3226))
([9f67457](9f67457))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmichalak @sfc-gh-jcieslak @sfc-gh-asawicki