feat: Task resource v1 readiness

docs/resources/resource_monitor.md

@@ -2,7 +2,7 @@
 page_title: "snowflake_resource_monitor Resource - terraform-provider-snowflake"
 subcategory: ""
 description: |-
-
+  Resource used to manage resource monitor objects. For more information, check resource monitor documentation https://docs.snowflake.com/en/user-guide/resource-monitors.
 ---
 
 !> **V1 release candidate** This resource was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the resource if needed. Any errors reported will be resolved with a higher priority. We encourage checking this resource out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960) to use it.
@@ -15,7 +15,7 @@ description: |-
 
 # snowflake_resource_monitor (Resource)
 
-
+Resource used to manage resource monitor objects. For more information, check [resource monitor documentation](https://docs.snowflake.com/en/user-guide/resource-monitors).
 
 ## Example Usage
 

pkg/acceptance/bettertestspoc/README.md

@@ -351,4 +351,5 @@ func (w *WarehouseDatasourceShowOutputAssert) IsEmpty() {
     1. Lists of objects are partially generated, and only parameter name is generated in some functions (the type has to be added manually).
     2. `testing` is a package name that makes Go think that we want to have unnamed parameter there, but we just didn't generate the type for that field in the function argument.
 - generate assertions checking that time is not empty - we often do not compare time fields by value, but check if they are set
+- Additional asserts for sets and lists that wouldn't rely on the order of items saved to the state (SNOW-1706544)
 - support generating provider config and use generated configs in `pkg/provider/provider_acceptance_test.go`

pkg/acceptance/bettertestspoc/assert/objectassert/task_snowflake_ext.go

@@ -72,3 +72,37 @@ func (t *TaskAssert) HasTaskRelations(expected sdk.TaskRelations) *TaskAssert {
 	})
 	return t
 }
+
+func (t *TaskAssert) HasWarehouse(expected *sdk.AccountObjectIdentifier) *TaskAssert {
+	t.AddAssertion(func(t *testing.T, o *sdk.Task) error {
+		t.Helper()
+		if o.Warehouse == nil && expected != nil {
+			return fmt.Errorf("expected warehouse to have value; got: nil")
+		}
+		if o.Warehouse != nil && expected == nil {
+			return fmt.Errorf("expected warehouse to no have value; got: %s", o.Warehouse.Name())
+		}
+		if o.Warehouse != nil && expected != nil && o.Warehouse.Name() != expected.Name() {
+			return fmt.Errorf("expected warehouse: %v; got: %v", expected.Name(), o.Warehouse.Name())
+		}
+		return nil
+	})
+	return t
+}
+
+func (t *TaskAssert) HasErrorIntegration(expected *sdk.AccountObjectIdentifier) *TaskAssert {
+	t.AddAssertion(func(t *testing.T, o *sdk.Task) error {
+		t.Helper()
+		if o.ErrorIntegration == nil && expected != nil {
+			return fmt.Errorf("expected error integration to have value; got: nil")
+		}
+		if o.ErrorIntegration != nil && expected == nil {
+			return fmt.Errorf("expected error integration to have no value; got: %s", o.ErrorIntegration.Name())
+		}
+		if o.ErrorIntegration != nil && expected != nil && o.ErrorIntegration.Name() != expected.Name() {
+			return fmt.Errorf("expected error integration: %v; got: %v", expected.Name(), o.ErrorIntegration.Name())
+		}
+		return nil
+	})
+	return t
+}

pkg/acceptance/bettertestspoc/assert/resourceassert/gen/resource_schema_def.go

@@ -97,4 +97,8 @@ var allResourceSchemaDefs = []ResourceSchemaDef{
 		name:   "StreamOnView",
 		schema: resources.StreamOnView().Schema,
 	},
+	{
+		name:   "Task",
+		schema: resources.Task().Schema,
+	},
 }

pkg/acceptance/bettertestspoc/assert/resourceassert/task_resource_ext.go

@@ -0,0 +1,18 @@
+package resourceassert
+
+import (
+	"fmt"
+	"strconv"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert"
+)
+
+func (t *TaskResourceAssert) HasAfterIds(ids ...sdk.SchemaObjectIdentifier) *TaskResourceAssert {
+	t.AddAssertion(assert.ValueSet("after.#", strconv.FormatInt(int64(len(ids)), 10)))
+	for i, id := range ids {
+		t.AddAssertion(assert.ValueSet(fmt.Sprintf("after.%d", i), id.FullyQualifiedName()))
+	}
+	return t
+}