Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean up environment variables in tests and on CI #2543

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chore: Clean up environment variables in tests and on CI #2543

merged 1 commit into from
Feb 23, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

Before fixing #2294 and #2242 we need to have a clean CI env. After this PR it should be possible to completely remove following environment variables from the secrets:

  • AWS_EXTERNAL_BUCKET_URL (it has TEST_SF_TF_AWS_EXTERNAL_BUCKET_URL replacement)
  • AWS_EXTERNAL_KEY_ID (it has TEST_SF_TF_AWS_EXTERNAL_KEY_ID replacement)
  • AWS_EXTERNAL_ROLE_ARN (it has TEST_SF_TF_AWS_EXTERNAL_ROLE_ARN replacement)
  • AWS_EXTERNAL_SECRET_KEY (it has TEST_SF_TF_AWS_EXTERNAL_SECRET_KEY replacement)
  • AZURE_EXTERNAL_BUCKET_URL (it has TEST_SF_TF_AZURE_EXTERNAL_BUCKET_URL replacement)
  • AZURE_EXTERNAL_SAS_TOKEN (it has TEST_SF_TF_AZURE_EXTERNAL_SAS_TOKEN replacement)
  • AZURE_EXTERNAL_TENANT_ID (it has TEST_SF_TF_AZURE_EXTERNAL_TENANT_ID replacement)
  • GCS_EXTERNAL_BUCKET_URL (it has TEST_SF_TF_GCS_EXTERNAL_BUCKET_URL replacement)
  • SKIP_EMAIL_INTEGRATION_TESTS (not used)
  • SKIP_EXTERNAL_TABLE_TEST (not used anymore)
  • SKIP_NOTIFICATION_INTEGRATION_TESTS (not used)
  • SKIP_STREAM_TEST (not used anymore)
  • SNOWFLAKE_ACCOUNT (we use the config now, this shouldn't be needed)
  • SNOWFLAKE_ACCOUNT_SECOND (not used anymore)
  • SNOWFLAKE_ACCOUNT_THIRD (not used anymore)
  • SNOWFLAKE_PASSWORD (we use the config now, this shouldn't be needed)
  • SNOWFLAKE_ROLE (we use the config now, this shouldn't be needed)
  • SNOWFLAKE_USER (we use the config now, this shouldn't be needed)

There are three more that should be removed but they should be approached more carefully:

  • SNOWFLAKE_WAREHOUSE (we do not have it in our config, so it is taken from env; test what happens without setting a warehouse by running the tests locally with the config similar to the CI one)
  • SNOWFLAKE_PORT (we do not have this in our config, let's check if the tests will work without this - they should not fail)
  • SNOWFLAKE_PROTOCOL (we do not have this in our config, there is a default, it should be fine without it)

@github-actions GitHub Actions
Copy link

Integration tests failure for f3dbd22f0d60b9061b3835e6ef3f76dd6592b265

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for f3dbd22f0d60b9061b3835e6ef3f76dd6592b265

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review February 23, 2024 08:29
@sfc-gh-asawicki sfc-gh-asawicki merged commit 9a10cb1 into main Feb 23, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the 2294-2242-fix-environment-variables-on-ci branch February 23, 2024 08:30
@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 23, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 28, 2024
@snowflake-release-please
chore(main): release 0.87.0 (#2513)
07ce00a 
🤖 I have created a release *beep* *boop*
---


##
[0.87.0](v0.86.0...v0.87.0)
(2024-02-28)


### 🎉 **What's new:**

* Add network rule to the sdk
([#2526](#2526))
([b379565](b379565))
* supports collation of table column
([#2496](#2496))
([56771f1](56771f1))


### 🔧 **Misc**

* Clean up environment variables in tests and on CI
([#2543](#2543))
([9a10cb1](9a10cb1))
* replace warning in new grant resources with info log
([#2521](#2521))
([c3014b9](c3014b9))


### 🐛 **Bug fixes:**

* data retention days follow up
([#2566](#2566))
([7aba384](7aba384))
* data retention time parameters
([#2502](#2502))
([76abf21](76abf21))
* data retention time parameters follow-up
([#2530](#2530))
([5544544](5544544))
* Demote warning to info and set volatility for procedures and functions
([#2567](#2567))
([abaad7c](abaad7c)),
closes
[#2536](#2536)
* Fix ACCOUNT PARAMETERS option failover group resource
([#2522](#2522))
([61883f3](61883f3)),
closes
[#2517](#2517)
* Fix failover group alter syntax and suppression for pipe statement
([#2562](#2562))
([24d76c3](24d76c3))
* Fix few tests
([#2515](#2515))
([a523a6b](a523a6b))
* Fix provider config hierarchy
([#2551](#2551))
([677a12b](677a12b))
* Fix query_results in unsafe_execute resource
([#2512](#2512))
([94ca158](94ca158)),
closes
[#2491](#2491)
* Fix replication for database resource
([#2524](#2524))
([767fbce](767fbce)),
closes
[#2021](#2021)
* Fix show by id for external functions
([#2531](#2531))
([d910a84](d910a84)),
closes
[#2528](#2528)
* Fix various small problems
([#2552](#2552))
([f558ce6](f558ce6))
* Granting database roles
([#2511](#2511))
([dc27d64](dc27d64)),
closes
[#2402](#2402)
* grants on external volumes
([#2538](#2538))
([1de9a29](1de9a29))
* Handle old reference for table_id in table constraint resource
([#2558](#2558))
([d1e8912](d1e8912)),
closes
[#2535](#2535)
* loosen identifier field validation for account object identifiers
([#2564](#2564))
([a5ed8cd](a5ed8cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-swinkler